Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to cabal-3.0 #340

Closed
4 of 10 tasks
chshersh opened this issue Aug 28, 2019 · 5 comments · Fixed by #555
Closed
4 of 10 tasks

Move to cabal-3.0 #340

chshersh opened this issue Aug 28, 2019 · 5 comments · Fixed by #555
Assignees
@chshersh @vrom911
Labels
CI CI tools support; project CI; build with different GHC, tools enhancement feature generated project Files, folder generation by the summoner
Milestone
v2.1: Modernize &...

Comments

@chshersh
Copy link
Contributor

chshersh commented Aug 28, 2019 •
edited

This change implies:

  • Changing defaultCabal
  • Removing v2- prefixes
  • Simplify cabal test (echo "No tests" no longer needed)
  • Add --write-ghc-environment-files=always option

The following files need to be changed:

  • .travis.yml
  • Generated .travis.yml
  • appveyor.yml
  • Generated appveyor.yml
  • .github/workflows/ci.yml
  • Generated .github/workflows/ci.yml
@chshersh chshersh added feature generated project Files, folder generation by the summoner CI CI tools support; project CI; build with different GHC, tools enhancement labels Aug 28, 2019
@chshersh chshersh added this to the v2.0: Major update milestone Aug 28, 2019
@vrom911
Copy link
Member

vrom911 commented Aug 29, 2019

And changing cabal version in .cabal file and .travis.yml.

@srid
Copy link
Collaborator

srid commented Sep 20, 2019

Future: generated default.nix

Could you elaborate on what this means? I thought default.nix is hand-written?

@chshersh
Copy link
Contributor Author

@srid The word generated in the context of this project means files and directories generated by summoner during his work. So ideally we are trying to use the same CI configs as summoner would generate during scaffolding. Dogfooding this project helps to improve UX 👍

After looking closely at default.nix again I don't see any cabal-related information in this package.... So we might not even need to change it at all if it uses cabal >= 3.0 by default.

@chshersh chshersh modified the milestone: v2.0: Major update Feb 22, 2020
@chshersh chshersh removed this from the v2.0: Major update milestone Mar 9, 2020
@chshersh chshersh pinned this issue May 6, 2020
@chshersh chshersh added this to the v2.1: Update milestone Jul 12, 2020
@chshersh chshersh mentioned this issue Oct 14, 2020
Merged
gdziadkiewicz added a commit to gdziadkiewicz/summoner that referenced this issue Oct 14, 2020
@gdziadkiewicz
[kowainik#454][kowainik#340] Move to Cabal 3.0
4c6fb6d
gdziadkiewicz added a commit to gdziadkiewicz/summoner that referenced this issue Oct 14, 2020
@gdziadkiewicz
[kowainik#454][kowainik#340] Move to Cabal 3.0
33a3982
gdziadkiewicz added a commit to gdziadkiewicz/summoner that referenced this issue Oct 14, 2020
@gdziadkiewicz
[kowainik#454][kowainik#340] Move to Cabal 3.0
6da1b70
@szabi
Copy link

szabi commented Nov 16, 2021

Is Grzegorz @gdziadkiewicz still working on this?

@gdziadkiewicz
Copy link
Collaborator

@szabi I'm not

chshersh added a commit that referenced this issue Jan 11, 2022
@chshersh
[#340] Move to cabal-3.0
12bc648 
Resolves #340
@chshersh chshersh mentioned this issue Jan 11, 2022
Merged
vrom911 pushed a commit that referenced this issue Jan 11, 2022
@chshersh
[#340] Move to cabal-3.0 (#555)
b8bf784 
* [#340] Move to cabal-3.0

Resolves #340

* Move GHC actions defaults to Summoner.Default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

@vrom911 vrom911

Labels
CI CI tools support; project CI; build with different GHC, tools enhancement feature generated project Files, folder generation by the summoner
Projects
None yet
Milestone
v2.1: Modernize & Resurrect
Development

Successfully merging a pull request may close this issue.

[#340] Move to cabal-3.0 kowainik/summoner
5 participants
@srid @szabi @chshersh @vrom911 @gdziadkiewicz