Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to choose any RGB color #51

Open
dariodsa opened this issue Dec 25, 2020 · 1 comment
Open

Ability to choose any RGB color #51

dariodsa opened this issue Dec 25, 2020 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@dariodsa
Copy link

As I saw currently user can only select colours mentioned in this data type.

https://github.com/feuerbach/ansi-terminal/blob/5d65f48485182320ea05f90b5b002003515c089b/src/System/Console/ANSI/Types.hs#L39-L47

There shouldn't be too difficult to add additional function and maybe data type to wrap Colour from colour package so that user can write a message with any foreground or background colour (thanks to the this line). That would require to add colour package in the dependency list and to add some additional function available for users. If you think that this is a good idea, I can start working on this.
🎄 🎅 🎁

@chshersh chshersh added enhancement New feature or request question Further information is requested labels Dec 27, 2020
@chshersh
Copy link
Contributor

Hi @dariodsa! I see that the SGR data type from the ansi-terminal library has the SetRGBColor constructor, that allows specifying the colour in RGB.

I don't mind introducing a function called rgb (as well as impure analogue in the spirit of our API). Feel free to start working on this 🙂 That would be really appreciated! ❤️

dariodsa added a commit to dariodsa/colourista that referenced this issue Apr 3, 2021
dariodsa added a commit to dariodsa/colourista that referenced this issue Apr 3, 2021
dariodsa added a commit to dariodsa/colourista that referenced this issue Apr 7, 2021
dariodsa added a commit to dariodsa/colourista that referenced this issue Apr 18, 2021
dariodsa added a commit to dariodsa/colourista that referenced this issue Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants