Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: compare with vuejs-smart-table #36

Open
mesqueeb opened this issue Sep 13, 2021 · 3 comments
Open

docs: compare with vuejs-smart-table #36

mesqueeb opened this issue Sep 13, 2021 · 3 comments
Labels
question Further information is requested

Comments

@mesqueeb
Copy link
Contributor

There's a very similar renderless library that does seemingly the same things:

https://github.com/tochoromero/vuejs-smart-table

I'd love some kind of comparison chart with pros and cons to this library vs vuejs-smart-table

@kouts
Copy link
Owner

kouts commented Sep 14, 2021

Hey @mesqueeb, comparing the two libraries doesn't belong inside the documentation from my perspective. It will probably be biased in favour of vue-dataset 😃 .
With that said, you can choose what feels right for you and share your findings with the community in this issue here.

@noogen
Copy link

noogen commented Apr 16, 2022

I feel that they're two different components that meet different needs. I like this one better because it's not tied to the HTML Element table as in vuejs-smart-table. Therefore, we can use CSS to render responsive display.

And if this is the path/route that this component is going, then I suggest allowing for changing CSS Classes of the component so we can apply custom CSS/other CSS Frameworks. Classes, such as pagination, page-item, and form-inline are too closely tired to bootstrap. Especially form-inline, which I don't think, even exists in bootstrap 5.

Ref: https://stackoverflow.com/questions/67655096/bootstrap-5-form-group-form-row-form-inline-not-working

@kouts
Copy link
Owner

kouts commented Apr 16, 2022

Hey @noogen, yes it makes sense. But for the time being even if you don't use Bootstrap you can:

  • Pass your own classes to dataset's components and style them to your liking.
  • Create your own dataset child components

Let's say you want to style the dataset-search component it would be something like:
<dataset-search ds-search-placeholder="Search..." class="my-search" />

and then in your styles:

.my-search input {
  border: 1px solid red;
}

@kouts kouts added the question Further information is requested label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants