Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from MD5 to BLAKE3? #3

Open
iamtakingithard opened this issue Nov 30, 2021 · 5 comments
Open

Switch from MD5 to BLAKE3? #3

iamtakingithard opened this issue Nov 30, 2021 · 5 comments

Comments

@iamtakingithard
Copy link
Collaborator

The BLAKE3 is a far more faster and better security. It will be a good replacement for MD5.
@iamtakingithard
Copy link
Collaborator Author

Holy shit, RustCrypto as library is very ancient and currently deprecated so I definetely take care of this.

@vaartis
Copy link
Member

vaartis commented Nov 30, 2021

MD5 was selected specifically because Erlang (and therefor pleroma) can do it natively. The security really doesn't matter that much here, because these are only alive for about a minute before becoming invalid, while using MD5 makes it easy to implement for whoever is using the service.

@iamtakingithard
Copy link
Collaborator Author

Alright, I will keep MD5 then.

@Your-New-SJW-Waifu
Copy link

What about something like SHA-256?

@vaartis
Copy link
Member

vaartis commented Jan 1, 2023

What about something like SHA-256?

Seems that erlang does support this one, but the change has to be backwards compatible somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vaartis @Your-New-SJW-Waifu @iamtakingithard