Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default connection pool when using defdb #382

Open
chenfisher opened this issue Jun 18, 2017 · 1 comment
Open

No default connection pool when using defdb #382

chenfisher opened this issue Jun 18, 2017 · 1 comment

Comments

@chenfisher
Copy link

The docs states that defdb creates a connection pool but from looking at the code and from testing real DB interaction using defdb it seems there's no connection pool. :make-pool is missing from the spec.

(defdb) creates a connection pool for your db spec (using the wonderful c3p0 library) to make sure resources are used efficiently. It also sets the last created pool as the default for all queries. As such, connection management is essentially taken care of for you.

Either the doc should be changed or defdb should add the :make-pool true to the spec

@rpazyaquian
Copy link
Contributor

Should a plain defdb call assume the user wants a connection pool by default? Is leaving it out unless the user explicitly asks for it the best/most straightforward option, or should it be the default regardless?

In either case, I agree that the docs should be more explicit about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants