New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Open links in PocketBook web browser #11782
Comments
But then it's probably completely fine to just make this available on modern PocketBooks, if that's something that can be done. |
That's totally ok. You can use PocketBook:getSoftwareVersion() No real idea about the minimum supported version but I guess you could try from the major version your firmware is currently in and assume all devices work the same. |
Well, that doesn't really solve anything. I can easily check for the existence of But the issue is that it needs to be declared first, and I'm not meant to change I can obviously just |
cool :)
It is totally ok to define platform's behaviour manually. see android cdefs Please keep I'm not very fan of our current base/front split so maybe others can give you some suggestion. |
Armed with https://ghidra-sre.org/, I've actually managed to make it work using |
Many PocketBook devices include a web browser, but when clicking a link in KOReader, there was no option to open the link in the browser, there was only an option to show a QR code (which can then be scanned by a smartphone). This commit implements `canOpenLink`/`openLink` on PocketBook using the "browser.app", if available. Tested on PB740 (InkPad 3). Fixes: koreader#11782 Related: koreader#6597
Many PocketBook devices include a web browser, but when clicking a link in KOReader, there was no option to open the link in the browser, there was only an option to show a QR code (which can then be scanned by a smartphone). This commit implements `canOpenLink`/`openLink` on PocketBook using the "browser.app", if available. Tested on PB740 (InkPad 3). Fixes: koreader#11782 Related: koreader#6597
Many PocketBook devices include a web browser, but when clicking a link in KOReader, there was no option to open the link in the browser, there was only an option to show a QR code (which can then be scanned by a smartphone). This commit implements `canOpenLink`/`openLink` on PocketBook using the "browser.app", if available. Tested on PB740 (InkPad 3). Fixes: koreader#11782 Related: koreader#6597
Many PocketBook devices include a web browser, but when clicking a link in KOReader, there was no option to open the link in the browser, there was only an option to show a QR code (which can then be scanned by a smartphone). This commit implements `canOpenLink`/`openLink` on PocketBook using the "browser.app", if available. Tested on PB740 (InkPad 3). Fixes: koreader#11782 Related: koreader#6597
Many PocketBook devices include a web browser, but when clicking a link in KOReader, there was no option to open the link in the browser, there was only an option to show a QR code (which can then be scanned by a smartphone). This commit implements `canOpenLink`/`openLink` on PocketBook using the "browser.app", if available. Tested on PB740 (InkPad 3) and PB624 (Basic Touch). On the older device (PB624) it doesn't work quite as well—an already running browser ignores the request to switch URL, but it doesn't work with the built-in book reader software either. Fixes: koreader#11782 Related: koreader#6597
Many PocketBook devices include a web browser, but when clicking a link in KOReader, there was no option to open the link in the browser, there was only an option to show a QR code (which can then be scanned by a smartphone). This commit implements `canOpenLink`/`openLink` on PocketBook using the "browser.app", if available. Tested on PB740 (InkPad 3). Fixes: #11782 Related: #6597
Many PocketBook devices include a web browser, but when clicking a link in KOReader, there's no option to open the link in the browser, there's only an option to show a QR code (which can then be scanned by a smartphone). It would be useful if KOReader offered an option to open it directly on the device browser itself.
I was able to make this work on PB740 (InkPad 3) using the following userpatch (1-pocketbook-browser.lua):
I'm now seeking advice how to proceed if I wanted to submit this to KOReader as a PR.
OpenTask
is not available in the old SDK that's used for building KOReader for PocketBook, and I was unable to make this work usingNewTask
(it works once and then keeps segfaulting). So I can't just addOpenTask
tobase/ffi-cdecl/inkview_decl.c
and use it.Any ideas?
(I'll keep playing with NewTask and other inkview stuff a bit more but I'm not super hopeful.)
The text was updated successfully, but these errors were encountered: