New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated options on Non-touch #11747
Comments
The former isn't supposed to show on non-touch devices. Maybe something like this would do the trick? diff --git a/frontend/apps/reader/modules/readerhighlight.lua b/frontend/apps/reader/modules/readerhighlight.lua
index e80998717..abba38f1f 100644
--- a/frontend/apps/reader/modules/readerhighlight.lua
+++ b/frontend/apps/reader/modules/readerhighlight.lua
@@ -593,6 +593,7 @@ Except when in two columns mode, where this is limited to showing only the previ
if not Device:isTouchDevice() and Device:hasDPad() then
menu_items.selection_text = util.tableDeepCopy(menu_items.long_press)
menu_items.selection_text.text = _("Select on text")
+ menu_items.long_press = nil
end
-- main menu Search |
that works! should I PR this or will you? |
If you have time to, please do. |
I found the [guilty] offender here #8608. 😂 |
But, with this line added, we do not need |
I tried to get it to work without |
You just have |
that was the very first thing I tried, and it didn't work for some reason. But now it does, weird. |
Issue
There is one option duplicated in the menus, one comes from --#8877 and later #8914-- the other not sure.
Both
NEW: Long-press on text
andSelect on text
appear to be the exact same thing with different names.Steps to reproduce
Open any book, go to "page with bookmark > NEW: Long-press on text" the other is found under "page with text > Select on text"
The text was updated successfully, but these errors were encountered: