Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] improve coscheduling's log #1895

Open
eahydra opened this issue Feb 6, 2024 · 3 comments · May be fixed by #2009
Open

[proposal] improve coscheduling's log #1895

eahydra opened this issue Feb 6, 2024 · 3 comments · May be fixed by #2009
Assignees
Labels
area/koord-scheduler good first issue Good for newcomers kind/proposal Create a report to help us improve
Milestone

Comments

@eahydra
Copy link
Member

eahydra commented Feb 6, 2024

What is your proposal:

The logs of CoScheduling Plugin needs to be optimized to remove unnecessary interference.

E.g.,

klog.Errorf("podGroup's annotation totalNumber illegal, gangName: %v, value: %v",
gang.Name, pg.Annotations[extension.AnnotationGangTotalNum])
totalChildrenNum = int64(minRequiredNumber)
} else if totalChildrenNum != 0 && totalChildrenNum < int64(minRequiredNumber) {
klog.Errorf("podGroup's annotation totalNumber cannot less than minRequiredNumber, gangName:%v, totalNumber: %v,minRequiredNumber: %v",
gang.Name, pg.Annotations[extension.AnnotationGangTotalNum], minRequiredNumber)
totalChildrenNum = int64(minRequiredNumber)
}

Why is this needed:

Is there a suggested solution, if so, please add it:

@eahydra eahydra added good first issue Good for newcomers area/koord-scheduler kind/proposal Create a report to help us improve labels Feb 6, 2024
@googs1025
Copy link
Contributor

/assign

@googs1025
Copy link
Contributor

Hello, could you please tell me more details? Is it about adjusting the log level and removing unnecessary log outputs?

@googs1025
Copy link
Contributor

@eahydra should we use klog.V(4).ErrorS(), This ensures log level printing and also reflects error messages

@googs1025 googs1025 linked a pull request Apr 17, 2024 that will close this issue
3 tasks
@ZiMengSheng ZiMengSheng added this to the v1.5 milestone May 7, 2024
@saintube saintube modified the milestones: v1.5, v1.6 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koord-scheduler good first issue Good for newcomers kind/proposal Create a report to help us improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants