Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default location_scale_bias badly tuned #600

Open
gonsolo opened this issue Jul 30, 2021 · 4 comments
Open

Default location_scale_bias badly tuned #600

gonsolo opened this issue Jul 30, 2021 · 4 comments

Comments

@gonsolo
Copy link

gonsolo commented Jul 30, 2021

I tried to search for two Bavarian cities and photon doesn't find them (Ingolstadt, Rosenheim). It works on komoot.de but doesn"t at https://photon.komoot.io. See the attached pictures.

ingolstadt_komoot
ingolstadt_photon

I found this problem with Gnome Maps: https://gitlab.gnome.org/GNOME/gnome-maps/-/issues/172

@lonvia lonvia changed the title Search doesn't work Location_scale_bias badly tuned Jul 30, 2021
@lonvia lonvia changed the title Location_scale_bias badly tuned Default location_scale_bias badly tuned Jul 30, 2021
@lonvia
Copy link
Collaborator

lonvia commented Jul 30, 2021

Looks like we need to tweak the default location bias scale some more. Search without location bias works fine: https://photon.komoot.io/api/?q=ingolstadt

Even a mild increase of location_scale_bias works wonders: https://photon.komoot.io/api/?q=ingolstadt&limit=5&lat=52.387963405382365&lon=13.058280944824219&debug=1&location_bias_scale=0.21

The search on the commercial Komoot website is unrelated.

@karussell
Copy link
Collaborator

karussell commented Dec 21, 2021

Another example are the tests in our converter:

https://photon.komoot.io/api/?q=beer&lat=48.774675&lon=9.172136&location_bias_scale=0.1

with bias = 0.1 the result is fine like Beerstraße or Immer.Beer.Herzen pub or Beeren-Brodbeck.

But when I increase the location bias I was expecting to get a result closer to the specified coordinate but the opposite happens:

https://photon.komoot.io/api/?q=beer&lat=48.774675&lon=9.172136&location_bias_scale=0.5

Update: Ah, wait. The documentation is:

Sensible values go from 0.0 (ignore prominence almost completely) to 1.0 (prominence has approximately the same influence). The default is 0.2.

Does this mean that the results are closer to the specified coordinates if the location bias is smaller? (this seems a bit counter intuitive to me)

@lonvia
Copy link
Collaborator

lonvia commented Dec 21, 2021

Yeah, it might have been better to switch that around. The given weight is applied to the importance. Too late to change now.

@karussell
Copy link
Collaborator

What if we deprecate this parameter and introduce a new one like location_bias with the more intuitive meaning?

gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jan 25, 2022
As a stop-gap solution for the location bias
issue in the Photon search engine
(komoot/photon#600),
for now limit the use of location bias to zoom
level above 17.

Ref #172
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 10, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 10, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 10, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 10, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 10, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 10, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 18, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 18, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 19, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
gnomesysadmins pushed a commit to GNOME/gnome-maps that referenced this issue Jun 19, 2022
Tweak the location_bias_scale parameter.
See: komoot/photon#600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants