Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display success message after transaction is in block #10231

Closed
exezbcz opened this issue May 5, 2024 · 4 comments · Fixed by #10293
Closed

Display success message after transaction is in block #10231

exezbcz opened this issue May 5, 2024 · 4 comments · Fixed by #10293
Assignees
Labels
A-modal issues related to modals enhancement New feature or request p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented May 5, 2024

Display success message after transaction is in block

with @vikiival we discussed that it should be possible (preview should be already ready to display in the modal"

Why it would be nice? Since the block time is quite long, and it takes ~30 seconds from signing to success, displaying the success message a bit earlier would decrease waiting times and make Polkadot feel a bit faster

Design and changes

  • after a transaction is in the block, display a success message
  • success message will have a different transaction status

image
https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=6886-20058&mode=design&t=neRjoavRuafpIGjV-11

When it gets confirmed, it switches to the "confirmed status"

@exezbcz exezbcz added UX first Improvement for UX enhancement New feature or request p2 core functionality, or is affecting 60% of app A-modal issues related to modals labels May 5, 2024
@Victor0355
Copy link

👋

@hassnian
Copy link
Contributor

@Victor0355 are you working on this ?

@hassnian
Copy link
Contributor

@preschian any way we can speed up this section,

section inside `useUpdateMetadata`

CleanShot 2024-05-14 at 17 05 01@2x

would like to show the success step before the transaction status moves to finalized

atm it's requiring the transaction to be finalized to get the index

@preschian
Copy link
Member

Ooh, I think it would be good if we could speed this up. This section is used to call the update metadata endpoint.

The solution I’m considering now is to create a queue service. Move that section to this service and ensure that the retry queue works if the index is not found or any other error occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-modal issues related to modals enhancement New feature or request p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants