Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ComponentMock to be compatible with the API on Svelte 3.46 #57

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Update ComponentMock to be compatible with the API on Svelte 3.46 #57

merged 2 commits into from
Feb 18, 2022

Conversation

cibernox
Copy link

Possibly also compatible with 3.40+.

Fixes #56

@kobejean
Copy link
Owner

Hi @cibernox thanks for the PR! It looks like some tests are failing unfortunately. I will take a look into the issue you've raised in #56 .

Thanks

@kobejean kobejean self-requested a review February 18, 2022 00:19
@kobejean kobejean changed the base branch from master to develop February 18, 2022 00:34
@kobejean
Copy link
Owner

There might be a few more changes I need to make so I will merge this into the develop branch and make further changes there. Again thanks!

@kobejean kobejean merged commit 58900f6 into kobejean:develop Feb 18, 2022
@cibernox cibernox deleted the update-for-svelte-3-46 branch February 23, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobejean kobejean Awaiting requested review from kobejean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MockComponentLatest.js is very outdated and doesn't work on recent version of svelte
2 participants
@cibernox @kobejean