Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate usage of KO_DOCKER_REPO #70

Open
imjasonh opened this issue May 1, 2023 · 0 comments
Open

Deprecate usage of KO_DOCKER_REPO #70

imjasonh opened this issue May 1, 2023 · 0 comments

Comments

@imjasonh
Copy link
Member

imjasonh commented May 1, 2023

Relying on this env var makes sense for ko as a standalone tool. In IaC it makes less sense.

A more idiomatic solution would be to use the provider-wide attribute fed by a variable, which can be fed by a variables file, or an environment variable if desired.

We should warn when KO_DOCKER_REPO is found to be load-bearing, and eventually remove the option for it to be used this way.

We might still want to warn if KO_DOCKER_REPO is set and we use the provider-specified value which is different, since this could be confusing for users using ko directly alongside the TF provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant