Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Issue, document.origin #2408

Closed
mcarpenterjr opened this issue Aug 23, 2018 · 3 comments
Closed

Deprecation Issue, document.origin #2408

mcarpenterjr opened this issue Aug 23, 2018 · 3 comments

Comments

@mcarpenterjr
Copy link

Just got this warning in the console when using the ko.toJS() method,

document.origin is deprecated and will be removed in M70, around October 2018. Please use self.origin (window.origin) instead. See https://www.chromestatus.com/features/5701042356355072 for more details.

Anyone aware of this? the timeline seems a little short.

@mcarpenterjr mcarpenterjr changed the title Deprication Issue, document.origin Deprecation Issue, document.origin Aug 23, 2018
@brianmhunt
Copy link
Member

Thanks @mcarpenterjr ; I can't seem to reproduce this. It would be odd if toJS were accessing document.origin in the ordinary course. Can you please provide a minimal test case?

@mcarpenterjr
Copy link
Author

I'm having some trouble creating a test case for it at the moment, the conditions it occurred under seem to be very specific. But after scanning the knockout repo it looks like there is no use of document.origin. So at this point, I'm guessing it's another library not in compliance. Thanks for the quick response, sorry there's not more here.

@brianmhunt
Copy link
Member

Thanks @mcarpenterjr — great to hear the problem lies elsewhere, and I hope you get it sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants