Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User preferences ignored #50

Open
funkypenguin opened this issue Feb 4, 2024 · 3 comments
Open

User preferences ignored #50

funkypenguin opened this issue Feb 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@funkypenguin
Copy link
Contributor

Hey all,

I've had a few users reporting this on reddit and in ElfHosted discord, haven't looked into it yet, but wanted to raise it incase anybody else has seen it, or incase I have a stupid misconfiguration bug somewhere :)

Describe the bug

When a user selects preferences like "no 4K, primary foreign language DE", these are ignored by the addon, and all results are still displayed when the user searches.

To Reproduce

Attempt to configure user preferences on https://torrentio.elfhosted.com/, observe that your preferences are not respected :)

Expected behavior

Preferences would affect the results return from a user search via the addon

@funkypenguin funkypenguin added the bug Something isn't working label Feb 4, 2024
@Gabisonfire
Copy link
Collaborator

Can confirm this is happening on my setup as well, might be related to #31

@purple-emily purple-emily self-assigned this Feb 4, 2024
Repository owner deleted a comment from nguyenquocngu93 Feb 4, 2024
@Ulinsky
Copy link

Ulinsky commented Feb 8, 2024

This is happening to me, this is the config Im using:
image
image

4k excluded, no foreign language, 2 results per quality.

And the result Im getting:
image

4k included, 2 results total instead of per quality, italian language instead of english for the 1080p result.

With the same torrentio config for the same episode:
image

these are the results Im getting:
image

either english or dual audio with english included, no 4k, 2 results per quality instead of 2 results total.

@dreulavelle
Copy link

Here is how I handle this in my other application. I've truncated it down some so that its more standalone here. The logic/methods are pretty straightforward. You'd just call parse method on a string, and it returns a dict. The fetch key is what you'd used to determine if the item is worth fetching or not. It's in python, so you'll need to convert.

Feel free to take what you can use, if its useful at all. Let me know if you have questions, I'm Spoked on discord.

https://github.com/dreulavelle/Nexus/blob/main/utils/parser.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants