command mode #92
command mode #92
Conversation
stokhos
force-pushed
the
command_mode
branch
3 times, most recently
from
2f4614c
to
7da272c
Compare
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.61 to 1.0.62. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.61...v1.0.62) Signed-off-by: dependabot[bot] <support@github.com>
minor fixes command modef minor imporovements command mode minor fixes asdf asdf
stokhos
force-pushed
the
command_mode
branch
from
7da272c
to
a4704de
Compare
minor fixes command modef minor imporovements command mode minor fixes asdf asdf
|
OK so I started writing a review for this, and I realised that implementing command mode in the current set-up is actually really hard (and needs knowledge of basically every part of the code). So I think it's probably best for both of us if I implement this. Please don't get me wrong - I really appreciate the work you're putting into Sapling and it's really nice to have help on a project like this, and I'm happy to give pointers and advice when needed 😁. But this specific PR will involves too many moving parts. If you really want to do this specifically, then I'll give you the help required, but I think it would probably involve many many rounds of code review and probably wouldn't be particularly interesting for you. I think the best thing for you to implement is the cursor undo (#88). |
|
No problem! |
I have done the implementation, I hope you can give me some feedback over this.
I added a
KeyMapfor each mode, those codes are duplicates. There should be a better way of doing this think.In vim's command mode, we press
: cmdand<cr>to execute that command. Should I do it now, or leave it for a another push, as this might relate toinsert mode?fixes #90