Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Support net-gateway-api #1285

Open
kahirokunn opened this issue Nov 8, 2022 · 10 comments
Open

Please Support net-gateway-api #1285

kahirokunn opened this issue Nov 8, 2022 · 10 comments
Labels
kind/feature-request lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@kahirokunn
Copy link
Contributor

Currently there is no entry for gateway-api in IngressConfigs.
It would be great if you could support net-gateway-api when it graduates from the sandbox!


https://github.com/knative-sandbox/net-gateway-api

@houshengbo
Copy link
Contributor

@kahirokunn Could you be more specific regarding this feature? Like is it just a new option to configure the knative serving to use gateway api? OR is it a replacement of how we currently configure the ingress?
There are tons of ingresses that support gateway api, how can we configure each of them as the ingress of knative serving?

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2023
@kahirokunn
Copy link
Contributor Author

Like is it just a new option to configure the knative serving to use gateway API

I am considering this one first.

There are tons of ingresses that support gateway api, how can we configure each of them as the ingress of knative serving?

I don't think it is necessary to consider which Ingress supports the Gateway API.
We believe it is sufficient to support the provision of HTTPRoute and gRPCRoute in the format supported by the standard Gateway API.
It is better for users to build their own Ingress that supports the Gateway API.
By the way, I would like to integrate cilium's Gateway API.

@kahirokunn
Copy link
Contributor Author

@houshengbo Sorry for the late reply.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 21, 2023
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2023
@kahirokunn
Copy link
Contributor Author

Keep

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2023
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 23, 2023
@kahirokunn
Copy link
Contributor Author

keep

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2023
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2023
@ReToCode ReToCode added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 22, 2023
@kahirokunn
Copy link
Contributor Author

@houshengbo

  1. allow config-gateway configuration
  2. install net-gateway-api
    This is all that is required.
    I don't think we need to provide the details for each vendor.
    For example, in the case of Cilium, it is as follows.
apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
spec:
  config:
    gateway:
      external-gateways: |
        - class: cilium
          gateway: knative-external-gateway/knative
          service: knative-external-gateway/cilium-gateway-knative
          supported-features:
          - Gateway
          - GatewayPort8080
          - GatewayStaticAddresses
          - HTTPRoute
          - HTTPRouteDestinationPortMatching
          - HTTPRouteHostRewrite
          - HTTPRouteMethodMatching
          - HTTPRoutePathRedirect
          - HTTPRoutePathRewrite
          - HTTPRoutePortRedirect
          - HTTPRouteQueryParamMatching
          - HTTPRouteRequestMirror
          - HTTPRouteRequestMultipleMirrors
          - HTTPRouteResponseHeaderModification
          - HTTPRouteSchemeRedirect
          - Mesh
          - ReferenceGrant
          - TLSRoute
      local-gateways: |
        - class: cilium
          gateway: knative-local-gateway/knative
          service: knative-local-gateway/cilium-gateway-knative
          supported-features:
          - Gateway
          - GatewayPort8080
          - GatewayStaticAddresses
          - HTTPRoute
          - HTTPRouteDestinationPortMatching
          - HTTPRouteHostRewrite
          - HTTPRouteMethodMatching
          - HTTPRoutePathRedirect
          - HTTPRoutePathRewrite
          - HTTPRoutePortRedirect
          - HTTPRouteQueryParamMatching
          - HTTPRouteRequestMirror
          - HTTPRouteRequestMultipleMirrors
          - HTTPRouteResponseHeaderModification
          - HTTPRouteSchemeRedirect
          - Mesh
          - ReferenceGrant
          - TLSRoute
    network:
      ingress-class: gateway-api.ingress.networking.knative.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants