Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional push in a Dependabot PR does not trigger actions #200

Closed
nak3 opened this issue Aug 7, 2023 · 7 comments
Closed

Additional push in a Dependabot PR does not trigger actions #200

nak3 opened this issue Aug 7, 2023 · 7 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@nak3
Copy link
Contributor

nak3 commented Aug 7, 2023

/area test-and-release
/kind bug

As got the answerd in https://github.com/orgs/community/discussions/62346 (Thanks @kvmware), we need to use Personal Access Token or GitHub App token to trigger github action when dependabot sends additional PR (after running hack script).

Should we add a "Personal Access Token" or "GitHub App token" for this? Or is there any other ideas?

Note There is one workaround which we can close&re-open the dependabot to trigger the githubaction.

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 7, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Aug 7, 2023

The Github app token would be preferable

@knative-prow
Copy link

knative-prow bot commented Sep 18, 2023

@nak3: The label(s) area/test-and-release cannot be applied, because the repository doesn't have them.

In response to this:

/area test-and-release
/kind bug

As got the answerd in https://github.com/orgs/community/discussions/62346 (Thanks @kvmware), we need to use Personal Access Token or GitHub App token to trigger github action when dependabot sends additional PR (after running hack script).

Should we add a "Personal Access Token" or "GitHub App token" for this? Or is there any other ideas?

Note There is one workaround which we can close&re-open the dependabot to trigger the githubaction.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso dprotaso transferred this issue from knative/pkg Sep 18, 2023
@dprotaso
Copy link
Member

/assign @kvmware

Can we look into using the prow bot's token (the one that does cherry-picks to also do these PR changes) ?

@krsna-m
Copy link
Contributor

krsna-m commented Sep 19, 2023

Yes, but I still think reusing a github app would be better even if it is prow's. @upodroid Do you have a suggestion?

Notes:

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2023
@dprotaso
Copy link
Member

@krsna-m is there any action here? seems like there was no resolution based on the discussion above

@dprotaso dprotaso reopened this Jan 18, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants