Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process for reporting issues with our images #136

Open
duglin opened this issue Apr 5, 2019 · 21 comments
Open

Process for reporting issues with our images #136

duglin opened this issue Apr 5, 2019 · 21 comments
Labels
kind/enhancement kind/good-first-issue Denotes an issue ready for a new contributor. kind/security Issues or PRs related to security or CVEs. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@duglin
Copy link

duglin commented Apr 5, 2019

I'm told that GCR will scan our images for vulnerabilities but there isn't yet a process in place for us to be notified when something of concern is detected. We need something to tell us of the issue so we can investigate/fix it.

@dlorenc @mattmoor
@jessiezcc
Copy link

This would be great value add, and we should have it for all knative related projects.

@mattmoor
Copy link
Member

@jessiezcc We already scan gcr.io/knative-releases. The question is how we're notified of the issues, and on what channels. @nbarthwal Dan's old team had infrastructure for this, so please coordinate with him before we roll out own.

@nbarthwal
Copy link

nbarthwal commented Apr 15, 2019 via email

@mattmoor
Copy link
Member

same as above :)

@adrcunha
Copy link

It seems that notifications are available through Pub/Sub: https://cloud.google.com/container-registry/docs/get-image-vulnerabilities

@adrcunha
Copy link

Nikhil left the team, assigning this issue to me.
/assign adrcunha
/unassign nbarthwal

@adrcunha
Copy link

Vulnerability scanning is now enabled for knative-nightly and knative-tests.

@adrcunha
Copy link

The missing part is subscribing to the pubsub topic and publishing it as e-mail. Joyce has the necessary knowledge for doing that.

/unassign adrcunha
/assign @yt3liu

@kramvan1
Copy link

@adrcunha Will the email list be open to users to get on? As a consumer of Istio, I would like to see the scan output. Maybe just use a new repo and create issues instead of email? or a repo wiki page for each scan?

@adrcunha
Copy link

That's a good idea, simple, effective and doable: creating an issue in the relevant repo.

@yt3liu yt3liu mentioned this issue Jul 23, 2019
Closed
@knative-housekeeping-robot
Copy link

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

@knative-prow-robot knative-prow-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2019
@adrcunha
Copy link

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2019
@adrcunha adrcunha added the kind/good-first-issue Denotes an issue ready for a new contributor. label Oct 29, 2019
@knative-housekeeping-robot
Copy link

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

@knative-prow-robot knative-prow-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2020
@duglin
Copy link
Author

duglin commented Jan 28, 2020

@adrcunha what's the status of this one?

@duglin
Copy link
Author

duglin commented Jan 28, 2020

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2020
@adrcunha
Copy link

@yt3liu started some work in knative/test-infra#1175 but AFAIK this is not a priority.

@knative-housekeeping-robot
Copy link

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

@knative-prow-robot knative-prow-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020
@duglin
Copy link
Author

duglin commented Apr 28, 2020

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2020
Cynocracy referenced this issue in Cynocracy/test-infra Jun 13, 2020
@mattmoor @knative-prow-robot
Implement workqueue.MetricsProvider (#678)
ecb9800 
The kubernetes workqueue provides a facility for collecting metrics by registering a workqueue.MetricsProvider
via workqueue.SetProvider.

This change implements that interface to expose the workqueue metrics into opencensus.

This is loosely based on some work started by @grantr [here](kubernetes-sigs/controller-runtime@master...grantr:opencensus-replace#diff-bb94124aff8d568cb4e82854c7d44fd1)

Fixes: knative/pkg#522
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen.Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2020
@mattmoor
Copy link
Member

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 27, 2020
@krsna-m
Copy link
Contributor

krsna-m commented Feb 23, 2022

/kind security

@knative-prow-robot knative-prow-robot added the kind/security Issues or PRs related to security or CVEs. label Feb 23, 2022
@upodroid upodroid added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jun 15, 2022
@upodroid upodroid transferred this issue from knative/test-infra Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement kind/good-first-issue Denotes an issue ready for a new contributor. kind/security Issues or PRs related to security or CVEs. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests