Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run func without HOME defined/ unaccessible .config dir #2236

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Mar 18, 2024

Changes

Use func without the need for HOME definition or accessible ~/.config with slightly limited functionality (like docker creds or local templates/repos)

TODO

  • default credential provider
    • tests
  • dont include option to save docker creds
  • builder tests
  • local repositories & its functiuons
  • new tests
  • fix existing tests
  • ?: remove createpaths from standard commands

/kind enhancement
/kind bug

Fixes #2150

Copy link

knative-prow bot commented Mar 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Mar 18, 2024
Copy link

knative-prow bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2024
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2024
@gauron99 gauron99 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 59.71%. Comparing base (b97d841) to head (7a6f6ea).
Report is 82 commits behind head on main.

Files Patch % Lines
pkg/docker/creds/credentials.go 83.33% 5 Missing and 1 partial ⚠️
pkg/builders/buildpacks/builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
- Coverage   64.21%   59.71%   -4.51%     
==========================================
  Files         108      127      +19     
  Lines       13918    14783     +865     
==========================================
- Hits         8937     8827     -110     
- Misses       4108     5063     +955     
- Partials      873      893      +20     
Flag Coverage Δ
e2e-test 38.38% <53.33%> (+1.00%) ⬆️
e2e-test-oncluster 31.47% <53.33%> (+0.96%) ⬆️
e2e-test-oncluster-runtime 27.64% <53.33%> (?)
e2e-test-runtime-go 26.18% <53.33%> (?)
e2e-test-runtime-node 27.19% <53.33%> (?)
e2e-test-runtime-python 27.14% <53.33%> (?)
e2e-test-runtime-quarkus 27.23% <53.33%> (?)
e2e-test-runtime-rust 26.28% <53.33%> (?)
e2e-test-runtime-springboot 26.30% <53.33%> (?)
e2e-test-runtime-typescript 27.28% <53.33%> (?)
integration-tests ?
unit-tests-macos-latest 47.96% <86.66%> (-0.89%) ⬇️
unit-tests-ubuntu-latest 49.04% <86.66%> (-0.55%) ⬇️
unit-tests-windows-latest 47.64% <81.08%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. kind/enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not fail if ~/.config is not writable
1 participant