New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum k8s requirement in the error log and doc #7813
Comments
@Leo6Leo: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Leo6Leo my concern is that we end up bloating the scripts with too many checks that we need to maintain as they are constantly changing, so I am not sure about this as it's very costly to maintan unless you know of a way that simple and doesn't require constant maintenance |
we can link to https://github.com/knative/community/blob/main/mechanics/RELEASE-SCHEDULE.md |
I'm thinking about making a special script that we run first. This script will check important things like if we have the right version of Kubernetes and if the If it is too complicated, I think it should be enough to indicate the requirement for min k8s version in |
@Leo6Leo maybe instead of bloating the shell scripts, we can add a check into the test entry point on the go side, then we can call https://github.com/knative/pkg/blob/main/version/version.go#L52 (which is what is used to check the version anyways). |
Describe the bug
Currently, when you are running ./hack/install.sh, and you have a Kubernetes version does not satisfy with the minimum k8s version as required by Knative as suggested here.
The error logs just shows "E2E Test Failed, Error generating manifests". But when you try to describe eventing-controller, you will find out that it is failing because k8s version check failed.
Expected behavior
If we can directly tell users that the minimum k8s version requirement is not met at the beginning, this can save them some time debugging the issue.
Also we should specify that there is a requirement for minimum k8s version in
DEVELOPMENT.md
.To Reproduce
Knative release version
Additional context
Add any other context about the problem here such as proposed priority
/good-first-issue
/help-wanted
The text was updated successfully, but these errors were encountered: