Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Repo: autoscaler-keda #1527

Open
10 of 14 tasks
skonto opened this issue Mar 8, 2024 · 14 comments
Open
10 of 14 tasks

New Repo: autoscaler-keda #1527

skonto opened this issue Mar 8, 2024 · 14 comments

Comments

@skonto
Copy link
Contributor

skonto commented Mar 8, 2024

Use this issue type to request a new repo in knative-extensions (or
knative, which may require additional discussion).

Repo information

Org: knative-extensions

Repo: autoscaler-keda

Go module (Optional): knative.dev/serving-keda

Purpose (Description): This project targets to be a drop in replacement for the Knative Serving autoscaler-hpa component,
using keda for hpa management. For more details and a demo check https://github.com/skonto/serving-keda/blob/main/README.md.

Sponsoring WG: Serving and Operations.

Related issue: knative/serving#14877

Actions to fulfill

This area is used to track the repo creation process.
The requestor and sponsoring WG lead should perform the steps listed below and cross out the checkmarks when done.
The TOC is involved only in the TOC Gate steps.

  • Add this issue to the TOC project board for review. You are responsible for moving your entry on the board to "Needs Discussion" or "In Progress" as you move forward in this checklist.

You may not be able to use the Projects quick menu on this page. In that case, go to the project board and use the Add cards interface.

  • Send a PR adding entries for this repo in /peribolos/knative-extensions.yaml. Please mind the alphabetical order when adding to a list.
    • Add the repository and a description.
    • Grant Knative Admin the admin privilege.
    • Grant the sponsoring WG the write privilege.

TOC Gate: Once the TOC has approved the above, it will merge and Peribolos will create an empty repository.

  • (golang) Send a PR to add aliases for knative.dev/$REPONAME import paths (sample).

  • Have a lead from the sponsoring WG bootstrap the Git repository by using an
    appropriate "template" repository (basic,
    sample-controller,
    sample-source).

    Follow the instructions from Creating a repository from a template

  • Send a PR adding the repo to knobots. Then run the community files update action to propagate new OWNER_ALIASES.

  • Add your GitHub Team to the OWNERS file for your repo.

  • Set up prow for a new repo

  • Bootstrap your CI jobs using hack project (look at other extensions repos for reference)

  • Create a sample PR to verify Prow (e.g., edit the boilerplate README)

  • Verify that within 24 hours the appropriate branch protections have been applied
    requiring tide to pass before PRs are merged.

  • (optional) Send a PR adding the repo to CLOMonitor (more information).

@skonto skonto changed the title New Repo: autoscaler-keda-hpa New Repo: custom-metrics-autoscaler Mar 8, 2024
@skonto
Copy link
Contributor Author

skonto commented Mar 8, 2024

cc @dprotaso @ReToCode

I am open to suggestions for the name.

@rhuss
Copy link
Contributor

rhuss commented Mar 8, 2024

Thanks for raising this, I think this would be a great addition.

wrt/ name, why not just autoscaler-keda (to align with autoscaler-hpa) ? I think this is simple and clearly states the purpose.

@ReToCode
Copy link
Member

+1 on Rolands proposal. This also points out that this is our "KEDA-integration".

@skonto skonto changed the title New Repo: custom-metrics-autoscaler New Repo: autoscaler-keda Mar 11, 2024
@skonto
Copy link
Contributor Author

skonto commented Mar 11, 2024

Changed to autoscaler-keda. Initially I had it autoscaler-keda-hpa but it is a bit verbose.

@dsimansk
Copy link
Contributor

+1 to the autoscaler-keda name.

It make senses in a greater picture with prefix associations to certain WG as well.

@skonto
Copy link
Contributor Author

skonto commented Mar 13, 2024

cc @davidhadas @cardil @upodroid @krsna-m any objections for approving this?

@upodroid
Copy link
Member

+1 from me

@davidhadas
Copy link
Contributor

hi,
As this is sponsored by Serving, we should wait for @dprotaso to comment before moving forward to create the repo.
Other than that, looks fine to me.

@dprotaso
Copy link
Member

+1 from me

@yuzisun
Copy link
Contributor

yuzisun commented Mar 31, 2024

+1 !!!!!!!! I have linked to the KServe issue kserve/kserve#3561

@tenzen-y
Copy link

Hi, knative folks 👋
Are there any updates to introduce KEDA extensions?
I'd be looking forward to adding this extension since I'd like to use Kserve's kserve/kserve#3561 feature.

@terrytangyuan
Copy link

terrytangyuan commented Apr 12, 2024

+1 This would be great to have. I left a comment in kserve/kserve#3561 (comment). Feel free to join and discuss how the integration looks like.

@skonto
Copy link
Contributor Author

skonto commented Apr 18, 2024

Are there any updates to introduce KEDA extensions?

I will start working on this next week. RH Serving folks are off this week.

@psschwei
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests