Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use ascii chars in progress indicator on win #459

Merged
merged 1 commit into from
Aug 5, 2021
Merged

fix: use ascii chars in progress indicator on win #459

merged 1 commit into from
Aug 5, 2021

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Aug 5, 2021 •
edited

  • 馃悰 Fix bug of progress indicator on windows (there were troubles with unicode chars)

resolves #352 #354

@matejvasek
fix: use ascii chars in progress indicator on win
8ad9df5 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2021
@zroubalik
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@knative-prow-robot knative-prow-robot merged commit 6fd42a4 into knative:main Aug 5, 2021
This was referenced Aug 5, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland Awaiting requested review from lkingland

@zroubalik zroubalik Awaiting requested review from zroubalik

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@lance lance Awaiting requested review from lance

Assignees

@zroubalik zroubalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[usability] Spinner for build and deploy commands does not look correct on Windows
3 participants
@matejvasek @knative-prow-robot @zroubalik