feat: print emit response output if it's a cloudevent #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CloudEvent SDK will provide any event included in the response as a
return value from `Request()`. If it does, print it out. It makes the
experience nicer.
For example, if I run the default TypeScript event function locally, this
is what `kn emit...` looks like.
```
❯ ./func emit --sink local --data '{"hello": "world"}'
Context Attributes,
specversion: 1.0
type: echo
source: function.eventViewer
id: d7d81ccc-a365-4433-be6b-7edfa43ca360
time: 2021-07-27T18:57:03.147Z
datacontenttype: application/json; charset=utf-8
Data,
{
"hello": "world"
}
```
Signed-off-by: Lance Ball <lball@redhat.com>
knative-prow-robot
added
approved
zroubalik
approved these changes
Jul 28, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
func emitgets a CloudEvent in response, print it for the userThe CloudEvent SDK will provide any event included in the response as a
return value from
Request(). If it does, print it out. It makes theexperience nicer.
For example, if I run the default TypeScript event function locally, this
is what
kn emit...looks like.Signed-off-by: Lance Ball lball@redhat.com
/kind enhancement
Fixes: #388
Release Note