Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builders version #421

Merged
merged 1 commit into from Jul 15, 2021
Merged

Update builders version #421

merged 1 commit into from Jul 15, 2021

Conversation

matejvasek
Copy link
Contributor

Changes

馃悰 Fix issues with --trust-builder=false

Newer builders use non-root user as specified in buildpacks spec

@matejvasek
Copy link
Contributor Author

/kind bug

@knative-prow-robot
Copy link

@matejvasek: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 15, 2021
@matejvasek matejvasek mentioned this pull request Jul 15, 2021
Merged
lkingland
lkingland approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@lkingland
Copy link
Member

(CI failure is fixed in #419)

@matejvasek
Copy link
Contributor Author

We need this to make podman work with v0.16.1.

@matejvasek
fix: update builders version
dff307d 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 15, 2021
@matejvasek
Copy link
Contributor Author

/lgtm

@knative-prow-robot
Copy link

@matejvasek: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor Author

matejvasek commented Jul 15, 2021 •
edited

@lkingland I rebased please re-lgtm.

@lkingland
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@knative-prow-robot knative-prow-robot merged commit 771a230 into knative:main Jul 15, 2021
@lance
Copy link
Member

lance commented Jul 16, 2021

type/bug

just testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@lance lance Awaiting requested review from lance

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matejvasek @knative-prow-robot @lkingland @lance