feat: add support for labels in func.yaml

[lance]

This change adds support for setting labels on deployed functions via func.yaml. The CLI will assume that func.yaml is the definitive source of information about what labels should exist on the deployed Service, and each deploy ensures that the labels in the deployed Service and what's in func.yaml are in sync.

Fixes: #261

Signed-off-by: Lance Ball lball@redhat.com

[zroubalik]

Looking good, minor nit: do we want to validate the specified labels in the func.yaml or do we want to keep the validation on the actual deployment process via Knative?

Documentation is missing for this field.

[zroubalik]

kn allows users to set and unset labels this way, I wonder whether there is possibility for us to use something similar:

  -l, --label stringArray                 Labels to set for both Service and Revision. name=value; you may provide this flag any number of times to set multiple labels.
                                          To unset, specify the label name followed by a "-" (e.g., name-).

[lance]

Looking good, minor nit: do we want to validate the specified labels in the func.yaml or do we want to keep the validation on the actual deployment process via Knative?

What kind of validation are you thinking of?

[lance]

kn allows users to set and unset labels this way,

For us, I suppose the -l flag would be only on deploy. Is this what you had in mind?

[zroubalik]

Looking good, minor nit: do we want to validate the specified labels in the func.yaml or do we want to keep the validation on the actual deployment process via Knative?

What kind of validation are you thinking of?

Just a check that the input value is a valid k8s label, as per: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set

But that's just a question, if we don't do the check it will fail during the deployment anyway.

[zroubalik]

kn allows users to set and unset labels this way,

For us, I suppose the -l flag would be only on deploy. Is this what you had in mind?

I just want to give users way how to remove a label, because the current solution allows only adding/updating labels, not removing (they would have to undeploy and deploy the function again in order to get rid of labels that were specified before).

I am not sure that the flag is the best solution, but what else do we have? 🤷‍♂️
(Maybe func config labels which would fetch all labels and then allow users to remove the specific ones?...)

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lance,lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lance]

I've updated this so that it's integrated with the interactive prompt that Zbynek recently introduced, and I have added tests. I think it should be ready for review. PTAL

/cc @zroubalik @lkingland @matejvasek

[matejvasek]

why is pkged.go modified?

[lance]

OK - one more time @lkingland @zroubalik and @matejvasek - sorry this has been so long in the making. I think finally it's good for a final review.

[lkingland]

/lgtm

[lkingland]

@lance a recent PR fixes the Makefile such that build again correctly omits updating pkged.go unless there has been changes in ./templates.

[zroubalik]

Lookin good, just a minor nit

[matejvasek]

/lgtm