Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabling Keda scale doesn't take effect #3669

Open
converge opened this issue Feb 5, 2024 · 3 comments · May be fixed by #3676
Open

disabling Keda scale doesn't take effect #3669

converge opened this issue Feb 5, 2024 · 3 comments · May be fixed by #3676
Assignees
@converge
Labels
area/control-plane kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)

Comments

@converge
Copy link
Member

converge commented Feb 5, 2024

Describe the bug
[ok] Setting configmap config-kafka-features / controller.autoscaler from disabled to enabled takes effect.
[failing] setting configmap config-kafka-features / controller.autoscaler from enabled to disabled doesn't takes effect.

Expected behavior
Setting configmap config-kafka-features / controller.autoscaler from enabled to disabled should delete related scale resources created when the flag is switched from disabled to enabled, it will include:

Keda: Scaled Object, Authentication Trigger
Others: ConsumerGroups?

To Reproduce

  1. configmap config-kafka-features / controller.autoscaler from disabled to enabled takes effect.
  2. setting configmap config-kafka-features / controller.autoscaler from enabled to disabled doesn't takes effect.
  3. kubectl get so -A

the expected behaviour is that the Keda objects would be deleted.

Knative release version
1.13 (eventing and serving)

Additional context
Add any other context about the problem here such as proposed priority
@converge converge added the kind/bug Categorizes issue or PR as related to a bug. label Feb 5, 2024
@Cali0707
Copy link
Member

Cali0707 commented Feb 5, 2024

@converge - we should not delete consumergroups when the flag is changed, but it should delete the KEDA stuff. Would you be interested in working on a fix for this?

/triage-accepted
/area control-plane

@Cali0707 Cali0707 added the triage/accepted Issues which should be fixed (post-triage) label Feb 5, 2024
@converge
Copy link
Member Author

converge commented Feb 5, 2024

@converge - we should not delete consumergroups when the flag is changed, but it should delete the KEDA stuff. Would you be interested in working on a fix for this?

/triage-accepted /area control-plane

Yes, I'll give it a try on my spare time.

@Cali0707
Copy link
Member

Cali0707 commented Feb 5, 2024

/assign @converge

@converge converge linked a pull request Feb 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@converge converge

Labels
area/control-plane kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
Eventing Kafka Broker Scheduling and Scaling
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove keda objects during reconciliation converge/eventing-kafka-broker
2 participants
@converge @Cali0707