Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please simplify the process for switching to plain-text system email #1734

Open
rt4mn opened this issue Feb 16, 2024 · 4 comments
Open

Please simplify the process for switching to plain-text system email #1734

rt4mn opened this issue Feb 16, 2024 · 4 comments
Labels
question Further information is requested

Comments

@rt4mn
Copy link

rt4mn commented Feb 16, 2024

Is your feature request related to a problem? Please describe.

I am currently 45 minutes into the process of following the steps outlined here to try and make system emails sent from us plain text rather then html. the Instructions at the end say:

To turn system e-mail templates to plaintext, remove <!doctype html> from base.html and remove all HTML tags from the templates while retaining the Go templating code.

That means I have to go through all 10 template files and remove all the html tags, and figure out how to format them with the Go templating code (thats everything between the {{}} right?). I have not even gotten to the part where I will need to edit listmonk's systemd file to add the custom path to this directory by adding the --static-dir=your/custom/path flag, and after that I'm going to need to figure out how to test all of the various ways the system can email folks.

Its a lot of rigamaroll to send plaintext email.

Describe the solution you'd like

Best: A global "send plain text system email only" option.

Good: maybe provide a different link that folks can wget in the You can fetch the static files with: step of the docs, such that when they wget those static files, everything in the sent emails is plaintext rather then requiring folks to manually edit them. I'd be happy to do pull request with all my plain text templates (right now I'm just trying to strip out the html so they should be the same) once I have verified that they work.

Intermediate / temp: update the documentation to better explain the process (IE, dont assume people automagically understand how to "remove all HTML tags from the templates while retaining the Go templating code.")

@rt4mn rt4mn added the enhancement New feature or request label Feb 16, 2024
@rt4mn
Copy link
Author

rt4mn commented Feb 16, 2024

I am now dealing with a bug where the public form to subscribe to a link is broken. When I run /var/www/listmonk/listmonk --static-dir=/path and visit the form page, I get the error

handlers.go:62: template: index.html:15:43: executing "header" at <.AssetVersion>: can't evaluate field AssetVersion in type main.tplData

I think its the same problem that this person is having, so I'll try pulling the 2.5.1 templates and working with those, but the fact that I had to do a bunch of searching and tinkering to debug the issue, and am going to have to manually modify a bunch of template files is a good highlight of the reason why requiring users to dig into the guts of their instillation via ssh (and telling them to download files that have data that dont work bc wrong version?) is not the right way to change how emails are formatted.

@knadh
Copy link
Owner

knadh commented Feb 19, 2024

Hi @rt4mn. If you want to send plain text e-mail campaigns, you just have to choose that format on the campaign UI. There's no need to customize system templates.

Copying and modifying static system templates is for the rare usecase when you also want to turn the automated system e-mails (opt-in, unsubscribe notifications etc.) also plaintext. Is that what you're trying to achieve?

@knadh knadh added question Further information is requested and removed enhancement New feature or request labels Feb 19, 2024
@rt4mn
Copy link
Author

rt4mn commented Feb 19, 2024

Copying and modifying static system templates is for the rare usecase when you also want to turn the automated system e-mails (opt-in, unsubscribe notifications etc.) also plaintext. Is that what you're trying to achieve?

Yup, this is what we want! We don't want the first "confirm your subscription" email that folks get to be an html formatted email, since the kinds of people who subscribe to our lists are the kinds of people who are inherently suspicious of html formatted email (we are a privacy and anti mass-surveillance advocacy org).

Just like how I dont want us to include tracking links in our email, I think its more in line with our stated goals and values to send only plain text email, even when its system email.

@rt4mn
Copy link
Author

rt4mn commented Feb 27, 2024

@knadh I'll reiterate that this is not a question. This is an enhament / feature request. Please make it simpler to send plain-text system email. we allready know how to send campaigns in plain text. We want to ensure that system email is also plaintext only.

Repository owner deleted a comment May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants