Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute as package on PyPI #50

Open
kmjennison opened this issue Apr 6, 2018 · 0 comments
Open

Distribute as package on PyPI #50

kmjennison opened this issue Apr 6, 2018 · 0 comments

Comments

@kmjennison
Copy link
Owner

kmjennison commented Apr 6, 2018

This should make the project easier to configure and use.

Move settings into a dfp-prebid-setup.yml that looks something like:

orders:
  - bidder_code: somebidder
    advertiser_name: Some DFP Advertiser
    order_name: My HB Order
    targeting:
      placement_names:
        - Some Placement
        - Another Placement
      # Not yet implemented
      ad_unit_names:
       - An ad unit
      # Not yet implemented, but would allow empty targeting
      run_of_network: false
      ## Could later add additional DFP targeting options
    # Or a string preset: "auto" / "dense" 
    prebid_price_buckets:
      - min: 0
        max: 20.00
        precision: 2
        increment: 0.10
    # Optional
    prebid_send_all_bids: false
    number_of_creatives_per_line_item: 4
    currency_code: USD
user:
  email_address: somebody@example.com
  path_to_googleads_file: ./googleads.yaml
options:
  create_advertiser_if_does_not_exist: true
  use_existing_order: false

Use a CLI, dfpprebid, with commands:

  • create-config: generates a template dfp-prebid-setup.yml file
  • run [ordername] [options]: sets up the order and line items for the order specified, using the config file
    • Args: --config-file-path, --googleads-file-path, --create-advertiser, --use-existing-order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant