Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Use mocha-phantomjs for phantomjs implementation #51

Open
kmiyashiro opened this issue Mar 8, 2013 · 10 comments
Open

Use mocha-phantomjs for phantomjs implementation #51

kmiyashiro opened this issue Mar 8, 2013 · 10 comments
Milestone

Comments

@kmiyashiro
Copy link
Owner

Output would allow for CI integration (#45) and way more reporters/flexibility. Need to look into how easy it would be to wrap in a task.

@imawuman
Copy link

mocha-phantomjs only supports running 1 test html/url at a time so you would need to take this into consideration. One feature that I like about grunt-mocha that mocha-phantomjs lacks is the filtering out of console.log() messages from the tests themselves

@jackcviers
Copy link

@kmiyashiro I could take a look at this if you'd like. From an example on pastebin I don't think it would be too difficult to implement/integrate with this plugin.

@davisford
Copy link

Hi, I'm experimenting with both right now. I have both mocha-phantomjs + grunt-mocha-phantomjs working and I also have grunt tasks to run the same tests via grunt-mocha.

Maybe I'm missing something but what is mocha-phantomjs bringing to the table that the current implementation here lacks? I have setup a CI job within Jenkins using the Tap reporter output and it seems to run just fine. The task to execute it is just something like grunt mocha:jenkins >> target\test-results.tap and I specify tap as the reporter in the grunt config. What else would mocha-phantomjs buy me?

Sorry for the questions, but I'm trying to navigate through the sea of many different options.

@imawuman
Copy link

how does the tap reporter work for you? #55 i couldn't get that to work

@FoxGit
Copy link

FoxGit commented Jun 19, 2013

Any update on Jenkins integration or code coverage functionality?

@kmiyashiro
Copy link
Owner Author

@FoxGit What are you looking for in terms of Jenkins integration? It fails Jenkins builds just fine, are you looking for pretty output? I have not even looked into code coverage yet.

@FoxGit
Copy link

FoxGit commented Jun 20, 2013

Indeed, my bad. Jenkins integration running the tests with phantomjs works just fine. Code coverage capabilities would be most appreciated however. Then you can run your tests in a browser, headless with PhantomJS on the Jenkins AND have a coverage report with one single plugin, that would be awesome!

@jackcviers
Copy link

@FoxGit @kmiyashiro There are other tools for code-coverage like mocha-cov
or Istanbul-mocha. Coverage reporting is probably a separate responsibility
from running the specs.
On Jun 20, 2013 2:48 AM, "FoxGit" notifications@github.com wrote:

Indeed, my bad. Jenkins integration running the tests with phantomjs works
just fine. Code coverage capabilities would be most appreciated however.
Then you can run your tests in a browser, headless with PhantomJS on the
Jenkins AND have a coverage report with one single plugin, that would be
awesome!


Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-19735716
.

@FoxGit
Copy link

FoxGit commented Jun 21, 2013

I don't think it's a seperate thing. Writing unit tests without knowing about the coverage sounds not right. However there are alternatives of course, I use grunt-mocha-test right know. But as I already use this plug-in an additional coverage feature would be nice to have. :)

@geekdave
Copy link

For anyone interested in code coverage enforcement for use with CI systems like Travis and Jenkins, see my comment in issue #44 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants