Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi-hole v6 will be an alpine-based container #252

Open
klutchell opened this issue Sep 24, 2023 · 10 comments
Open

Pi-hole v6 will be an alpine-based container #252

klutchell opened this issue Sep 24, 2023 · 10 comments

Comments

@klutchell
Copy link
Owner

pi-hole/docker-pi-hole#1430 (comment)

We should be prepared to make compatibility changes.

@eiddor
Copy link
Collaborator

eiddor commented Sep 25, 2023

image

Alpine or Android?

@eiddor
Copy link
Collaborator

eiddor commented Sep 25, 2023

If it's Alpine, it shouldn't be a big hairy deal - If it's Android, then...

@klutchell klutchell changed the title Pi-hole v6 will be an android-based container Pi-hole v6 will be an alpine-based container Sep 25, 2023
@klutchell
Copy link
Owner Author

I was on my phone, it must have auto-corrected.

Yeah, I don't think we will need to change much except some of the packages we install, and the commands we run to set console fonts.

@eiddor
Copy link
Collaborator

eiddor commented Sep 25, 2023

Ok whew! Is it worth messing with the upstream Dockerfile and testing now or should we just wait until it actually happens?

@klutchell
Copy link
Owner Author

I think just wait, we are in no rush and it will be much easier knowing with confidence what we are working with.

@DL6ER
Copy link

DL6ER commented Nov 30, 2023

It may be worth mentioning that the v6 container is now available for some time:

version: "3"
services:
 pihole:
   image: pihole/pihole:development-v6

@klutchell
Copy link
Owner Author

Good to know! If I get some time this holiday season I might draft an example PR with the required changes to support v6.

@klutchell
Copy link
Owner Author

@DL6ER are we also moving away from s6-overlay by the looks of it? I can go look up the exact changes myself when I dig into it but I high level view of the planned changes would be handy.

@DL6ER
Copy link

DL6ER commented Dec 1, 2023

@PromoFaux is the docker master, he'd be the best to answer any questions

@PromoFaux
Copy link

Master is one word for it. Fake it till you make it I guess!

Yeah, s6-overlay is gone. We took the opportunity to do a complete overhaul - basing on alpine has been a long time goal, so it was a good time to start from scratch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants