Skip to content
This repository has been archived by the owner on Jan 22, 2023. It is now read-only.

A possible GoogleApiClient leak in 'NotificationCompose' #143

Open
AICT20 opened this issue Sep 27, 2020 · 0 comments
Open

A possible GoogleApiClient leak in 'NotificationCompose' #143

AICT20 opened this issue Sep 27, 2020 · 0 comments

Comments

@AICT20
Copy link

AICT20 commented Sep 27, 2020

'NotificationCompose' extends 'Compose' and calls its own 'setUpReplyText' method in onCreate.
However, I find that 'finish' method can be called in 'setUpReplyText', which can skip the onStop method according to Android documents. Meanwhile, in 'Compose', GoogleApiClient is required in onCreate while released in onStop, there may be a case that GoogleApiClient is never released when 'finish' is called, isn't it?

Maybe a better solution is to override the 'finish' method and release the GoogleApiClient in it if not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant