Remove jwt-decode as a peerDependency

[pirelenito]

We should extract the component that uses it on its own package.

Wdyt @deepsweet @xaviervia ?

[pirelenito]

Another option would be to make it as a dependency (I looked and it is not that big), ship the package as ES2015 modules and let clients deal with not being bundle by simple tree-shaking.

[deepsweet]

monorepo

[pirelenito]

Yep! That is even better... mono repo the shit out of these hocs so that they are published individually.

[deepsweet]

as an example https://github.com/deepsweet/hocs

[pirelenito]

Fantastic! Should we make this happen?

[deepsweet]

Does Sagui support it as well as multiple builds?

node_modules/@hocs/with-lifecycle
├── dist
│   ├── with-lifecycle.js
│   └── with-lifecycle.min.js
├── es
│   └── index.js
├── lib
│   └── index.js
└── package.json

[pirelenito]

But with lerna, it would be basically multiple packages, each with their own package.json \ sagui.

But given these are just libraries, we can also just use Babel and Jest directly. We don't need the webpack for anything anyway.

[deepsweet]

Well, React itself and many ecosystem packages transpiles to dist/ folder with Webpack as well to be able to use it on JS Bin etc.

node_modules/recompose/build/
├── Recompose.js
└── Recompose.min.js

[deepsweet]

Actually the right name for this folder is umd.

[pirelenito]

Gotcha, we can do that as well.

[pirelenito]

Either way, the monorepo solution sounds like a "major" endeavor, and I need the jwt-decode fixed ASAP.

I'll prepare a first PR that simply adds it as an official dependency, and we can do the monorepo as a propper long term fix latter.

Sound good?

[deepsweet]

Good.

[xaviervia]

Let’s do it!

🐒repo!

(🐒 is "mono" in Spanish)

[pirelenito]

btw, https://github.com/hocs is not taken... kinda like... it is wanting for a org to rise on it!

[deepsweet]

I registered it and then deleted 2 days ago :) Decided that mono repo should be really mono.

[xaviervia]

But it can be a the mono repo of the org!

[xaviervia]

Imagine that, we can have an org with a mono repo that repos all the monos!

[deepsweet]

and there will be only one repo called hocs, so github.com/hocs/hocs. yo dawg.

[xaviervia]

exactly