Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

Split the FPS higher-order component into two #26

Open
xaviervia opened this issue May 30, 2017 · 2 comments
Open

Split the FPS higher-order component into two #26

xaviervia opened this issue May 30, 2017 · 2 comments

Comments

@xaviervia
Copy link
Contributor

  • One (possibly withFPSGauge) should just report the fps as a prop and provide the onFPS callback
  • Another one (possibly withLowFPSReport) should have the current API, and build around the withFPSGauge
@xaviervia xaviervia mentioned this issue May 30, 2017
Closed
@Nevon
Copy link
Member

Nevon commented May 30, 2017

Obviously this is just nitpicking, but why FPSGauge? withFPS or withFPSMetric seems like a more obvious name.

@xaviervia
Copy link
Contributor Author

withFPS sounded too generic to me. I don’t know though, naming is hard, and naming this abstract stuff is even harder.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nevon @xaviervia