Skip to content

Commit f261141

Browse files
committed
Do not use innerHTML assignments
Fixes #98
1 parent c344fb3 commit f261141

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

modal/message/message.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,14 @@
44
function fillText(message){
55
document.querySelector("title").textContent = message.title;
66
const textNode = document.querySelector(".text");
7-
textNode.textContent = message.text;
8-
textNode.innerHTML = textNode.innerHTML.replace(/\n/g, "<br>");
7+
let first = true;
8+
message.text.split(/\n/g).forEach(function(line){
9+
if (!first){
10+
textNode.appendChild(document.createElement("br"));
11+
}
12+
first = false;
13+
textNode.appendChild(document.createTextNode(line));
14+
});
915
document.getElementById("ok").textContent = browser.i18n.getMessage("modal.message.ok");
1016
}
1117

releaseNotes.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ changes:
1010
- update client.js to version 1.9.1
1111

1212
fixes:
13-
-
13+
- do not use innerHTML assignments
1414

1515
Version 1.7
1616

0 commit comments

Comments
 (0)