New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure host ends in a slash #245
Conversation
Also updated specs that check equality of host or host + path to expect trailing slash for host.
This is in reference to #236. |
@kjvarga anything I should do for this pull request? |
raise SitemapGenerator::SitemapError, "No value set for #{key}" unless self[key] | ||
end | ||
|
||
def assert_slash(key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename append_slash
Sorry to take so long. I've commented. |
Hi @kjvarga, I can revert the changes to the specs, but the problem will be that all specs that test |
So any further thoughts on this, @kjvarga? |
I came back to this. I wasn't happy with modifying the host, and thought to rather just ensure a slash is present when the url is constructed. But I can't reproduce an error. The Are you able to provide me an example where it fails? I can't reproduce. |
See the comment here. #236 |
Also updated specs that check equality of host or host + path to expect
trailing slash for host.