Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Support for Pushover.net #6

Open
scottbindas opened this issue Oct 22, 2021 · 10 comments
Open

Enhancement - Support for Pushover.net #6

scottbindas opened this issue Oct 22, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@scottbindas
Copy link

For those IOS users, PushBullet no longer offers an IOS App. Pushover.net supports both IOS/Google apps.

It would be desirable that to also expose their "Message Priority" function so that for a larger county that has many FD's you can push FD Alerts for surrounding departments but allow them to be configured where a silent alert is all that is needed.

@Joey40
Copy link

Joey40 commented Jun 23, 2022

Unfortunate that PushBullet decided to drop support for iOS and apparently never revisited this decision. Would love to see support for an alternative.

@kdolan kdolan added the enhancement New feature or request label Jul 23, 2022
@kdolan kdolan self-assigned this Jul 23, 2022
@kdolan
Copy link
Contributor

kdolan commented Jul 23, 2022

This is planned

@ComputerComa
Copy link

ComputerComa commented Sep 7, 2022

Just wanted to note I have kinda started working on this as it is a feature that I would like to see.
You can follow my progress here.
I'm not sure if I am going about it correctly or not, so feel free to contact with suggestions or advice.
Really love the project!
Thanks, ComputerComa

@kdolan
Copy link
Contributor

kdolan commented Sep 9, 2022

Looks good so far! You will just need to finish implementing notifiers/index.js and add some tests and I would be happy to get that merged!

@ComputerComa
Copy link

Yeah, that was where I kinda hit a wall, I'm not sure I quite understand how to actually finish implementing it.

@kdolan
Copy link
Contributor

kdolan commented Sep 12, 2022

@ComputerComa You are SOO close.

  1. Add a method to https://github.com/ComputerComa/fd-tone-notify/blob/daa2e3c7e22c5e771920a6cf9c6b9a80f4f18aff/notifiers/index.js called _pushoverNotifications(params, prePostType)
  2. Add method to https://github.com/ComputerComa/fd-tone-notify/blob/daa2e3c7e22c5e771920a6cf9c6b9a80f4f18aff/obj/NotificationParams.js for getPushovers()
  3. Finish implementing the _pushoverNotifications(params, prePostType) method. You should be able to pretty closely copy the pattern for PushBullet.
  4. Test your code and see if it works!

@ComputerComa
Copy link

I think I'm pretty much finished. I'm not quite sure I have it implemented right though. Pushover registers as a notifier but never actually fires off. I did a test with the included tone examples and it catches it, (I edited the included example config to use pushover as the only notifier) but it just says in the debug logs that there are no PRE or POST notifications for pushover.

@kdolan
Copy link
Contributor

kdolan commented Sep 21, 2022

@ComputerComa It looks like you just forgot to add the new methods to the pre/post notifications methods.
If you add here and here those notifications should start processing.

@ghost
Copy link

ghost commented Jun 18, 2023

I think I'm pretty much finished. I'm not quite sure I have it implemented right though. Pushover registers as a notifier but never actually fires off. I did a test with the included tone examples and it catches it, (I edited the included example config to use pushover as the only notifier) but it just says in the debug logs that there are no PRE or POST notifications for pushover.

Do you still have the code? I am trying to setup my whole county however I realized that pushbullet is not on iOS

@ComputerComa
Copy link

I think I'm pretty much finished. I'm not quite sure I have it implemented right though. Pushover registers as a notifier but never actually fires off. I did a test with the included tone examples and it catches it, (I edited the included example config to use pushover as the only notifier) but it just says in the debug logs that there are no PRE or POST notifications for pushover.

Do you still have the code? I am trying to setup my whole county however I realized that pushbullet is not on iOS

I unfortunately don't anymore. It was on an old laptop that I no longer have

@kdolan kdolan added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants