Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic GPflow support #178

Merged
merged 2 commits into from Jun 15, 2021
Merged

feat: add basic GPflow support #178

merged 2 commits into from Jun 15, 2021

Conversation

kjappelbaum
Copy link
Owner

@kjappelbaum kjappelbaum commented Jun 14, 2021

This GPFlow support is really basic as the range of types of models you can build with GPFlow is just too wide to handle in one class.

I somehow could not train the GPRs in separate processes, using ThreadPoolExecutor for this reason, but this is more of a temporary fix.

  • Breaking change (fix or feature that would cause existing functionality to change)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation
  • Developer tools
  • Refactoring
  • Test

Actions (for code changes)

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kjappelbaum kjappelbaum linked an issue Jun 14, 2021 that may be closed by this pull request
@kjappelbaum kjappelbaum marked this pull request as draft June 14, 2021 11:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #178 (dbc5b12) into master (0ae381c) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   96.07%   96.22%   +0.15%     
==========================================
  Files          15       16       +1     
  Lines        1120     1167      +47     
==========================================
+ Hits         1076     1123      +47     
  Misses         44       44              
Flag Coverage Δ
unittests 96.22% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyepal/pal/pal_gpflowgpr.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae381c...dbc5b12. Read the comment docs.

@kjappelbaum kjappelbaum marked this pull request as ready for review June 14, 2021 13:00
@kjappelbaum kjappelbaum requested a review from byooooo June 14, 2021 13:01
Copy link
Collaborator

@byooooo byooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@byooooo byooooo merged commit 69a8bec into master Jun 15, 2021
@kjappelbaum kjappelbaum deleted the feat_gpflow branch May 12, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement gpflow support
3 participants