feat: add option to schedule reclassification of all points #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 96.07% 95.84% -0.23%
==========================================
Files 15 15
Lines 1120 1131 +11
==========================================
+ Hits 1076 1084 +8
- Misses 44 47 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
not really sure why coverage dropped with adding a test ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to fix a quite annoying behavior of the algorithm in case the initial GPR predictions are bad. This might lead to points being discarded that are actually dominating points that we later classify as Pareto optimal.
The current implementation can do nothing for it as we just take the GPR predictions for granted and might discard points based on mediocre GPR predictions in the the first iterations.
Similar to the hyperparameter schedule option we now have a
_should_reclassifyfunction that users can customize. By default, it will reclassify the full design space if there is only one point left. But users might choose any other schedule.@byooooo I have some compute i need to burn this month, let's make a plan for benchmarking this.
However, I think, we can merge without the benchmark.
Types of changes
Actions (for code changes)