Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue for the failing nets for single metal #92

Open
kjappelbaum opened this issue Jul 21, 2022 · 12 comments
Open

issue for the failing nets for single metal #92

kjappelbaum opened this issue Jul 21, 2022 · 12 comments
Assignees

Comments

@kjappelbaum
Copy link
Owner

i think the issue is that the branching sites are not in the node molecule, this might make an issues if we then do the matching

@kjappelbaum kjappelbaum self-assigned this Jul 21, 2022
@kjappelbaum
Copy link
Owner Author

the issue might be that the shortest path between metal and the branching site does not include the "complete" Hs and so on - perhaps we should switch from shortest path to something like BFS or all paths

Screen Shot 2022-07-22 at 00 02 07

@kjappelbaum
Copy link
Owner Author

perhaps all_simple_paths can do the job

@kjappelbaum
Copy link
Owner Author

all_simple_paths didn't do the issue, but neither did adding the neighbors.

I'm not sure anymore if this is the problem

@kjappelbaum
Copy link
Owner Author

rsm3434 is PIQMUZ_clean

@kjappelbaum
Copy link
Owner Author

the extra C i see does not appear in the crystal structure and seems to be a bug

@kjappelbaum
Copy link
Owner Author

3434 is indeed a diamondid network as the linker is an edge

@kjappelbaum
Copy link
Owner Author

perhaps our simplification doesn't work correctly here

@kjappelbaum
Copy link
Owner Author

ok, the results show that the issue might be that we do not have all the relevant branching coordinates in this node

Screen Shot 2022-07-22 at 08 59 45

@kjappelbaum
Copy link
Owner Author

indeed, we only see two, which is wrong

Screen Shot 2022-07-22 at 09 00 44

@kjappelbaum
Copy link
Owner Author

but we have 4 original graph branching indices

@kjappelbaum
Copy link
Owner Author

this was the issue, adding the branching site back fixed it

@kjappelbaum
Copy link
Owner Author

rsm3434 is relatively sensitive to symmetrization
i do not like that

@kjappelbaum kjappelbaum linked a pull request Nov 6, 2022 that will close this issue
@kjappelbaum kjappelbaum removed a link to a pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant