Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiwix-serve index page computation is too expensive #143

Closed
kelson42 opened this issue Dec 31, 2017 · 2 comments
Closed

kiwix-serve index page computation is too expensive #143

kelson42 opened this issue Dec 31, 2017 · 2 comments

Comments

@kelson42
Copy link
Contributor

This is in particulary true if many ZIM files are loaded. IMO it is acceptable to read the ZIM files metadata one time to build that index page one time, but then there is not reason anymore. This page, and everything needed to build it should be cached in memory.

This ticket is strongly linked to #142 and #139

@mgautierfr
Copy link
Member

As said in #140, the index page is already generate only once at the launch of kiwix-serve process. kiwix-serve only serve a static content when a browser request for the index page.

@kelson42
Copy link
Contributor Author

kelson42 commented Jan 9, 2018

@mgautierfr Thank you for this clarification. I thought I was able to generate a CPU pick each time I ask for the welcome page... but now I can't. Probably this caching system needs at some point to be extended a bit to sotre also favicon images as soon as they won't be in base64 encoding anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants