Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant "try ... except: raise" code #8429

Open
Julian-O opened this issue Oct 30, 2023 · 3 comments · May be fixed by #8436
Open

Remove redundant "try ... except: raise" code #8429

Julian-O opened this issue Oct 30, 2023 · 3 comments · May be fixed by #8436
Assignees
@p0lygun
Labels
easy Should be easy to fix

Comments

@Julian-O
Copy link
Contributor

Julian-O commented Oct 30, 2023 •
edited

Software Versions

  • Python: N/A
  • OS: N/A
  • Kivy: 2.2.1
  • Kivy installation method: N/A

There is a pattern (I count 10 examples of it) that look like this:

try:
     # some sort of import code
except:
    raise

The try block achieves nothing and should be removed (while leaving the wrapped code) to simplify the code.

(Often then imports can then be cleaned up)
@Julian-O Julian-O added easy Should be easy to fix Type: Bug A bug or something not working as intended labels Oct 30, 2023
@p0lygun
Copy link
Contributor

p0lygun commented Oct 30, 2023

Is this up for grabs? I would like to work on this.. also I would not call this a bug.. maybe we need a new label for "refactoring"

@Julian-O Julian-O removed the Type: Bug A bug or something not working as intended label Oct 31, 2023
@p0lygun
Copy link
Contributor

p0lygun commented Nov 3, 2023

ok starting the work on this

@baseplate-admin
Copy link
Contributor

ok starting the work on this

Great :D
Do you have an ETA?

@p0lygun p0lygun linked a pull request Nov 5, 2023 that will close this issue
Draft
7 tasks
@Julian-O Julian-O mentioned this issue Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0lygun p0lygun

Labels
easy Should be easy to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Try/Except and code around it p0lygun/kivy
3 participants
@Julian-O @p0lygun @baseplate-admin