Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename torch module #659

Closed
louisfh opened this issue Feb 14, 2023 · 0 comments
Closed

Rename torch module #659

louisfh opened this issue Feb 14, 2023 · 0 comments
Labels
rename Requests to rename variables, functions, classes
Milestone

Comments

@louisfh
Copy link
Member

louisfh commented Feb 14, 2023

It is confusing, and might be a problem that we have a dependency and module with the same name (torch and /opensoundscape/torch). I propose we change the name of our torch module.

One example of the issue this can cause.
When running import opensoundscape on a machine where you have a copy of the opensoundscape repo you may get ModuleNotFoundError: No module named 'torch._C'

This happens if your working directory is the /opensoundscape directory - as python does not know whether to import our torch module, or the package torch. In one case, even after changing working directory the error persists. I don't understand that.

Here's a comparable issue someone else had
pytorch/pytorch#574

@sammlapp sammlapp added the rename Requests to rename variables, functions, classes label Feb 27, 2023
@sammlapp sammlapp added this to the 0.9.0 milestone Mar 16, 2023
@sammlapp sammlapp added the resolved_in_branch The issue has been resolved in a feat/issue branch but not merged into develop label Mar 28, 2023
@sammlapp sammlapp added resolved_in_develop The issue has been resolved in the develop branch but not in master and removed resolved_in_branch The issue has been resolved in a feat/issue branch but not merged into develop labels Apr 7, 2023
@sammlapp sammlapp removed the resolved_in_develop The issue has been resolved in the develop branch but not in master label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rename Requests to rename variables, functions, classes
Projects
None yet
Development

No branches or pull requests

2 participants