Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging interceptors should log, not print #814

Open
2x2xplz opened this issue Jul 27, 2021 · 1 comment
Open

Logging interceptors should log, not print #814

2x2xplz opened this issue Jul 27, 2021 · 1 comment

Comments

@2x2xplz
Copy link

2x2xplz commented Jul 27, 2021

Logging interceptors should log, not print

Description

LogRequestInterceptor, LogRequestAsCurlInterceptor, and LogResponseInterceptor don't utilize any logging frameworks or APIs, they simply println() their output. I'd suggest proper integration with slf4j or similar logging API. Among other benefits, it would allow devs to set proper levels (INFO, ERROR, etc) based on context (i.e. successful/failed requests).
@SleeplessByte
Copy link
Collaborator

We'll take a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SleeplessByte @2x2xplz