Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic 1 2005 Compatibility #72

Open
IsoKilo opened this issue Mar 7, 2024 · 4 comments
Open

Sonic 1 2005 Compatibility #72

IsoKilo opened this issue Mar 7, 2024 · 4 comments

Comments

@IsoKilo
Copy link

IsoKilo commented Mar 7, 2024

It seems that in adding compatibility with the GitHub disassembly's use of mapmacros, 2005 users have been left behind. Loading doesn't work out of the box because Flex 2 can't assume that the base offset of the mappings is 0. And saving forces it into the mapmacros format. I understand that the GitHub disassembly and mapmacros are the standard now, but some of us like to do things the old fashioned way.

@kirjavascript
Copy link
Owner

You can save in the existing format by editing the mapping script to remove the mapmacros part. The next version will have a checkbox to disable this on the fly without having to edit the mapping script.

Not sure what you mean about assuming the base offset. Loading should still work fine, do you have an example?

@IsoKilo
Copy link
Author

IsoKilo commented Mar 7, 2024

image
The label Map_Sonic is kept outside of the mapping file itself. So when Flex2 attempts to load it this error pops up
image
This was not an issue in previous versions

@kirjavascript
Copy link
Owner

Ah thanks for the example!

I'll get this fixed for the next version that I hope to have out soon with a bunch of new features and fixes.

@MDTravisYT
Copy link

I've found a simple way to fix this was to include an older version of the Sonic 1 script in your scripts folder. I have both scripts present in my setup, with the current one labeled as "Sonic 1 MapMacros".
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants