Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite strip has wrong zoom #52

Open
flamewing opened this issue Jan 23, 2023 · 2 comments
Open

Sprite strip has wrong zoom #52

flamewing opened this issue Jan 23, 2023 · 2 comments

Comments

@flamewing
Copy link

While trying out the new release, I noticed that the fix for issue #45 unfortunately seems not to pick a good zoom at all. This is more apparent for larger sprites, such as Vector in the this screenshot:

image

In comparison to the previous version, the sprites in the right strip all have the same zoom level (which is great) but almost all of the frames visible are cropped.

@kirjavascript
Copy link
Owner

I thought you would pick a manual zoom

have you seen the zoom range input? the "slider" at the bottom on the sprites pane?

does it just need documentation?
or do you also want adaptive zoom on any sprite update?

@kirjavascript
Copy link
Owner

I guess I had adaptive zoom before per-sprite. maybe it should use that code and pick the one with the most macro zoom and use it for all? and then allow manual override?

at what point do you apply the macro zoom selection? on object load? or always and remove the range input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants