Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theming] Add configuration APIs for color chooser panels #459

Open
kirill-grouchnikov opened this issue Jan 23, 2024 · 1 comment
Open
Assignees
Labels
7.5 - Larimar Release 7.5 - 2024.H1

Comments

@kirill-grouchnikov
Copy link
Owner

See #457 (comment)

@kirill-grouchnikov kirill-grouchnikov added the 7.5 - Larimar Release 7.5 - 2024.H1 label Jan 23, 2024
@kirill-grouchnikov kirill-grouchnikov self-assigned this Jan 23, 2024
@ed-erwin-tf
Copy link

The comment that I made that started this was: "PS: It would be really nice if there were a setting somewhere to disable drawing the color name in this panel." (in reference to the crayon panel.)

I later figured out that I could hide the color names (in order to avoid translating to 15 languages) by simply translating all the color names to invisible characters, such as a space character. So, I don't really need that.

You said: "An API to configure the color chooser would be a nice addition, something along the lines of an enum that lists all available panels, and allows the app to choose which ones to display and in which order."

Improvements are possible, but please do not take away the ability for me to add my own custom color chooser panels. I have needed to do so to fix issues with existing panels in-between your releases. The existing mechanism UIManager.put("ColorChooser.defaultChoosers", new String[] {}); works well for me. I think that you are not a fan of putting constants into UIManager, but please keep some mechanism that allows me to keep using custom panels. An enum might not be as extendable as the string-based existing mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.5 - Larimar Release 7.5 - 2024.H1
Projects
None yet
Development

No branches or pull requests

2 participants