Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test fails even if pre-built... #8

Closed
AubreyHewes opened this issue Oct 4, 2017 · 5 comments
Closed

CI test fails even if pre-built... #8

AubreyHewes opened this issue Oct 4, 2017 · 5 comments

Comments

@AubreyHewes
Copy link
Member

It seems that the CI is not using the post-build lib to run tests..

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
@AubreyHewes
Copy link
Member Author

AubreyHewes commented Oct 12, 2017

The tests are run on the pre-babel code (esnext code (sic)). Though run on a "min-req" node container. This fails.

We should CI as

  • babel the code
  • test the "babeled" code
  • npm publish the babeled code

see #7

@fruitl00p
Copy link
Member

seems about right... but we could also create a new 3.0.0 release and target node 6+ (or even 8+) and leave the babel for what it is...?

@AubreyHewes
Copy link
Member Author

AubreyHewes commented Oct 12, 2017

The root problem is The tests are run on the pre-babel code. We want the code to have "old" support.. but we are testing on "new" code in an "old" env.
So it fails

@AubreyHewes
Copy link
Member Author

Currently the tests are run by the engine version.
Maybe update to a node-latest build container ... with n ...

  • babel the code
  • test the code
  • n to min-req version
  • test the code

?

@Reggino
Copy link
Member

Reggino commented Oct 20, 2017

This is fixed

@Reggino Reggino closed this as completed Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants