Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktk.cycles: cycle selection #35

Open
felixchenier opened this issue Mar 31, 2021 · 0 comments
Open

ktk.cycles: cycle selection #35

felixchenier opened this issue Mar 31, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@felixchenier
Copy link
Collaborator

Obsolete (or not) the numerous parameters of detect_cycle, and instead program:

detect_cycles(ts, event_name1, event_name2, thresholds, min_duration1, max_duration1, ....) -> TimeSeries

find_cycles(ts, event_name1, event_name2, min_duration1, max_duration1, ...) -> List[int]

remove_cycles(ts, event_name1, event_name2, i_cycles: List[int]) -> TimeSeries

We put criteria in detect_cycles to avoid detecting glitches, but we search for cycles using find_cycles to remove cycles that are cycles, but that we don't want to analyze.

Photo_on_2021-03-26_at_08 03_copy

@felixchenier felixchenier added the enhancement New feature or request label Mar 31, 2021
@felixchenier felixchenier added this to the 0.5 milestone Mar 31, 2021
@felixchenier felixchenier self-assigned this May 25, 2021
@felixchenier felixchenier removed this from the 0.5 milestone May 25, 2021
felixchenier added a commit that referenced this issue May 25, 2021
…on of more functionality and in prevision of #35.
@felixchenier felixchenier removed their assignment Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant