Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktk.Player should warn if markers of same name were found in different input TimeSeries #214

Open
felixchenier opened this issue Dec 5, 2023 · 1 comment
Open

ktk.Player should warn if markers of same name were found in different input TimeSeries #214

felixchenier opened this issue Dec 5, 2023 · 1 comment
Assignees
@felixchenier
Milestone
0.15

Comments

@felixchenier
Copy link
Collaborator

At the moment, Player quietly merges every TimeSeries provided as an input. But if two TimeSeries have similar names, one will take precedence and it's (1) not documented which; (2) confusing if we really wanted to explore two movements and see only one.

I don't think that marker names should be modified automatically, because it would break the interconnections argument. However we should get a warning.
@felixchenier felixchenier added this to the 1.0 milestone Dec 5, 2023
@felixchenier felixchenier self-assigned this Dec 5, 2023
@felixchenier
Copy link
Collaborator Author

Will be integrated in #215

@felixchenier felixchenier modified the milestones: 1.0, 0.15 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixchenier felixchenier

Labels
None yet
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
1 participant
@felixchenier