Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ktk.cycles.detect_cycles to an extension #189

Open
felixchenier opened this issue Jul 28, 2023 · 0 comments
Open

Move ktk.cycles.detect_cycles to an extension #189

felixchenier opened this issue Jul 28, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@felixchenier
Copy link
Collaborator

This function is very specific (it only finds biphasic cycles based on a treshold method), and it has two mixed purposes (detecting and filtering cycles). It's not particularly well written, and it does not implement a published or standard method that most could agree with. Therefore it doesn't belong to KTK's core, at least not yet.

@felixchenier felixchenier added this to the 1.0 milestone Jul 28, 2023
@felixchenier felixchenier self-assigned this Jul 28, 2023
@felixchenier felixchenier added the enhancement New feature or request label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant